Skip to content

Commit

Permalink
feat: Remove references to github issues. They are redundant.
Browse files Browse the repository at this point in the history
  • Loading branch information
devanbenz committed Dec 16, 2024
1 parent 2d9294c commit cc7163a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions tsdb/engine/tsm1/compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ func (c *DefaultPlanner) PlanOptimize() ([]CompactionGroup, int64, int64) {
}

// If there is a single generation, no tombstones, and the entire group size (all TSM files in the generation)
// is over or equal to 2 GB (Max TSM file size) there is nothing to do and we will return. Please see: https://github.com/influxdata/plutonium/issues/4201
// is over or equal to 2 GB (Max TSM file size) there is nothing to do and we will return.
// for more information regarding this logic.
if len(generations) == 1 && generations[0].size() >= uint64(maxTSMFileSize) && !generations.hasTombstones() {
return nil, 0, 0
Expand Down Expand Up @@ -925,7 +925,7 @@ func (c *Compactor) compact(fast bool, tsmFiles []string, logger *zap.Logger) ([
// Sets the points per block size. The larger this value is set
// the more points there will be a single index. Under normal
// conditions this should always be 1000 but there is an edge case
// where this is increased. See: https://github.com/influxdata/plutonium/issues/4201
// where this is increased.
size := c.Size
if size <= 0 {
size = tsdb.DefaultMaxPointsPerBlock
Expand Down
4 changes: 0 additions & 4 deletions tsdb/engine/tsm1/compact_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2337,7 +2337,6 @@ func TestDefaultPlanner_PlanOptimize_LargeMultiGeneration(t *testing.T) {

// This test is added to account for a single generation that has a group size
// under 2 GB so it should be further compacted to a single file.
// Please see: https://github.com/influxdata/EAR/issues/5531
func TestDefaultPlanner_PlanOptimize_SmallSingleGeneration(t *testing.T) {
// ~650 MB total group size
data := []tsm1.FileStat{
Expand Down Expand Up @@ -2381,7 +2380,6 @@ func TestDefaultPlanner_PlanOptimize_SmallSingleGeneration(t *testing.T) {

// This test is added to account for a single generation that has a group size
// under 2 GB and has less then level 4 files it should be further compacted to a single file.
// Please see: https://github.com/influxdata/EAR/issues/5531
// FullyCompacted should NOT skip over opening this shard.
func TestDefaultPlanner_PlanOptimize_SmallSingleGenerationUnderLevel4(t *testing.T) {
// ~650 MB total group size
Expand Down Expand Up @@ -2422,7 +2420,6 @@ func TestDefaultPlanner_PlanOptimize_SmallSingleGenerationUnderLevel4(t *testing

// This test is added to account for a single generation that has a group size
// under 2 GB so it should be further compacted to a single file.
// Please see: https://github.com/influxdata/EAR/issues/5531
// FullyCompacted should NOT skip over opening this shard.
func TestDefaultPlanner_FullyCompacted_SmallSingleGeneration(t *testing.T) {
// ~650 MB total group size
Expand Down Expand Up @@ -2462,7 +2459,6 @@ func TestDefaultPlanner_FullyCompacted_SmallSingleGeneration(t *testing.T) {
// This test is added to account for halting state after
// TestDefaultPlanner_FullyCompacted_SmallSingleGeneration
// will need to ensure that once we have single TSM file under 2 GB we stop
// Please see: https://github.com/influxdata/EAR/issues/5531
func TestDefaultPlanner_FullyCompacted_SmallSingleGeneration_Halt(t *testing.T) {
// ~650 MB total group size
data := []tsm1.FileStat{
Expand Down

0 comments on commit cc7163a

Please sign in to comment.