Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filling alert details template with HTML fields/tags #2246

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SuddenSelect
Copy link

@SuddenSelect SuddenSelect commented Sep 5, 2019

Alerts' details (email body) can currently be enhanced by using HTML tags, however embedding there Field or Tag value (ex. {{ index .Fields "someField" }} ) automatically triggers html escaping on said value (as per example here)
While this is a sensible default behavior, it unnecessarily limits Users flexibility when creating HTML-rich email notifications, and from a User's perspective seems counter-intuitive - some email body elements can have HTML and some cannot.

Proposed solution introduces a new function to template function map for encapsulation of given string in a type html/template/HTML as suggested here.

Added tests are based on TestStream_AlertEmail.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

@SuddenSelect
Copy link
Author

2 out of 3 containers in CircleCI job seem to time-out on apt-get setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant