Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove usages of github.com/pkg/errors dependency (archived) #12787

Merged
merged 1 commit into from
Mar 3, 2023
Merged

chore: Remove usages of github.com/pkg/errors dependency (archived) #12787

merged 1 commit into from
Mar 3, 2023

Conversation

zak-pawel
Copy link
Collaborator

github.com/pkg/errors has been deprecated and archived: pkg/errors#245

I don't think we still need to use it after all error wrapping done in #12701 #12702 #12704 #12723 #12731 #12733 #12772 and enabling errorlint for guarding it in #12785.

It needs to still be our indirect dependency and cannot be removed from LICENSE_OF_DEPENDENCIES.md because docker still uses it:

go mod why github.com/pkg/errors

# github.com/pkg/errors
github.com/influxdata/telegraf/plugins/inputs/docker
github.com/docker/docker/api/types/filters
github.com/pkg/errors

@telegraf-tiger telegraf-tiger bot added the chore label Mar 3, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 3, 2023

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 3, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @zak-pawel!

@srebhan srebhan merged commit d59ea7d into influxdata:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants