-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use --scan-open instead of --scan of smartctl to provide correct… #15724
Conversation
Thanks so much for the pull request! |
!signed-cla |
use smartctl --scan-open instead of smartctl --scan, see https://www.smartmontools.org/ticket/811
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding of scan open is it also tries to open the device. I think this is fine given we already need elevated privileges.
Please also update the README and sample.conf files to say we use scan-open instead of scan as well:
- readme: configuration (or update the sample config and run
make docs
) - readme: debugging issues section
- sample.conf: above devices_include/devices_exclude
Reflect the parameter change of smartctl when doing device scan.
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Keep in mind that devices in SLEEP and STANDBY modes may spin up when using |
… device type info
Summary
see #15723 , address incorrect device type information by smartctl --scan
Checklist
Related issues
resolves #15723