feat(processors.enum): Allow mapping to be applied to multiple fields #16030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
Hipska
approved these changes
Nov 4, 2024
DStrand1
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
reviewed
Nov 13, 2024
| fieldFilter, err := filter.NewIncludeExcludeFilter([]string{mapping.Field}, nil) | ||
| mapping.Fields = append(mapping.Fields, mapping.Field) | ||
| } | ||
| if len(mapping.Fields) != 0 { |
There was a problem hiding this comment.
The length check is not required. filter.Compile will return nil, nil in case of an empty list...
|
Why don't we also make this change for tags at the same time as well? |
Hipska
reviewed
Nov 14, 2024
Comment on lines
+20
to
+21
| FieldFilter filter.Filter | ||
| TagFilter filter.Filter |
There was a problem hiding this comment.
Probably doesn't need to be exported?
|
I also think the previous behaviour is changed: [[inputs.mock]]
metric_name = "mock"
[[inputs.mock.constant]]
name = "status"
value = "green"
[[inputs.mock.constant]]
name = "status_reverse"
value = "green"
[[processors.enum]]
[[processors.enum.mapping]]
field = "status"
[processors.enum.mapping.value_mappings]
green = 1
amber = 2
red = 3
[[processors.enum.mapping]]
field = "status_reverse"
[processors.enum.mapping.value_mappings]
green = 3
amber = 2
red = 1Currently results in: - > mock status="green",status_reverse="green"
+ > mock status=1i,status_reverse=3iAnd I think with this PR, it will result in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
fieldsoption to the enum processor, deprecating the oldfieldoption. Allows mapping multiple fields with one enum mapping when a glob does not workChecklist
Related issues
resolves #10892