feat(inputs.huebridge): Make inputs.huebridge an internal plugin #16352
+959
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
… and test logging
srebhan
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks @hdecarne for your contribution and sorry for this taking so long! I do have a very first comments in the code.
Additionally, I suggest splitting the code into some more files to make the plugin code more readable. How about defining a bridge type for handling all the discovery stuff, resource gathering and actual data gathering and keep the plugin code to manage the calls to the different bridges? The new type could then more to an own file for readability...
hdecarne
force-pushed
the
huebridge-plugin
branch
from
72ba9a1 to
ed96fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides the inputs.huebridge plugin for collecting Smart Home statistics.
It gathers status from Hue Bridge devices using the device's CLIP API.
I previously contributed this plugin as an external one. As part of the latest reworks I also converted it into an internal one.
Checklist
Related issues
resolves #16351