sanitize sorting to use valid identifiers #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
querypackage by adding validation for field identifiers in sorting criteria and introducing tests to ensure robustness against SQL injection attempts. Key changes include the addition of a regular expression for field validation, updates to theParseSortingfunction to enforce this validation, and new test cases to verify these improvements.Validation Enhancements:
query/sorting.go: IntroducedFieldIdentifierRegex, a regular expression to validate field names in sorting criteria. This ensures that field names follow a predefined format.query/sorting.go: Updated theParseSortingfunction to validate field names usingFieldIdentifierRegexand to check for empty field names, returning appropriate error messages when validation fails.Test Improvements:
query/sorting_test.go: Added a new test case,TestParseSortingInjection, to verify that theParseSortingfunction handles invalid input and prevents SQL injection attempts.