Skip to content

Commit

Permalink
[Fix] Make secret optional for TSIG Key (#17)
Browse files Browse the repository at this point in the history
* marked secret as optional

* set server default value as empty string

* marked default for name in zone an empty string

* marked default for name in zone an empty string

* removed default values

* modified documentation

* modified models

* modified models

* Removed record and host changes

---------

Co-authored-by: Ujjwal Nasra <[email protected]>
  • Loading branch information
VishrutiBuddhadev and unasra authored Jan 23, 2025
1 parent 414a67a commit 33c8db5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/keys/docs/TSIGKey.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Name | Type | Description | Notes
**id** | **str** | The resource identifier. | [optional] [readonly]
**name** | **str** | The TSIG key name in the absolute domain name format. |
**protocol_name** | **str** | The TSIG key name supplied during a create/update operation that is converted to canonical form in punycode. | [optional] [readonly]
**secret** | **str** | The TSIG key secret as a Base64 encoded string. |
**secret** | **str** | The TSIG key secret as a Base64 encoded string. | [optional]
**tags** | **object** | The tags for the TSIG key in JSON format. | [optional]
**updated_at** | **datetime** | Time when the object has been updated. Equals to _created_at_ if not updated after creation. | [optional] [readonly]

Expand Down
3 changes: 2 additions & 1 deletion src/keys/models/tsig_key.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class TSIGKey(BaseModel):
description=
"The TSIG key name supplied during a create/update operation that is converted to canonical form in punycode."
)
secret: StrictStr = Field(
secret: Optional[StrictStr] = Field(
default=None,
description="The TSIG key secret as a Base64 encoded string.")
tags: Optional[Dict[str, Any]] = Field(
default=None, description="The tags for the TSIG key in JSON format.")
Expand Down

0 comments on commit 33c8db5

Please sign in to comment.