Merge branch 'tkt_298_fix_invicti' into 'dev'

fix invicti plugin

Closes #298

See merge request faradaysec/faraday-plugins!226

CHANGELOG/current/298.md

@@ -0,0 +1 @@
+[FIX] Fix inviti's plugin, check remedial procedures before parsing it with b4f. #298

faraday_plugins/plugins/repo/invicti/DTO.py

@@ -87,7 +87,10 @@ def name(self) -> str:
 
     @property
     def severity(self) -> str:
-        return self.node.find('severity').text
+        sv = self.node.find('severity').text
+        if sv == "BestPractice":
+            sv = "Information"
+        return sv
 
     @property
     def confirmed(self) -> str:

faraday_plugins/plugins/repo/invicti/plugin.py

@@ -85,12 +85,16 @@ def parseOutputString(self, output):
         h_id = self.createAndAddHost(ip)
         s_id = self.createAndAddServiceToHost(h_id, url.scheme, ports=433)
         for vulnerability in parser.invicti.vulnerabilities:
-            vuln = {"name": vulnerability.name, "severity": vulnerability.severity,
-                    "confirmed": vulnerability.confirmed,
-                    "desc": BeautifulSoup(vulnerability.description, features="lxml").text,
-                    "path": vulnerability.url.replace(parser.invicti.target.url, ""),
-                    "external_id": vulnerability.look_id,
-                    "resolution": BeautifulSoup(vulnerability.remedial_procedure, features="lxml").text}
+            vuln = {
+                "name": vulnerability.name,
+                "severity": vulnerability.severity,
+                "confirmed": vulnerability.confirmed,
+                "desc": BeautifulSoup(vulnerability.description, features="lxml").text,
+                "path": vulnerability.url.replace(parser.invicti.target.url, ""),
+                "external_id": vulnerability.look_id
+            }
+            if vulnerability.remedial_procedure:
+                vuln["resolution"] = BeautifulSoup(vulnerability.remedial_procedure, features="lxml").text
             if vulnerability.classification:
                 references = []
                 if vulnerability.classification.owasp: