Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of oplog dependency #1032

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented Jul 23, 2024

By:

  • Replacing Cursor#observeChanges calls with MongoDB change streams
  • Disabling the oplog
  • Caching Meteor subscription handles
  • Using only async data fetching primitives

This is progress on:

Supersedes:

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 89.14382% with 194 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (922e877) to head (aa8dff8).
Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
imports/api/query/watch.ts 75.00% 20 Missing and 6 partials ⚠️
...s/ui/patients/PatientPersonalInformationStatic.tsx 48.78% 18 Missing and 3 partials ⚠️
imports/lib/async/lock.ts 45.45% 18 Missing ⚠️
imports/api/publication/useFind.ts 78.72% 10 Missing ⚠️
imports/api/createTagCollection.ts 25.00% 9 Missing ⚠️
...i/patients/usePatientPersonalInformationReducer.ts 55.00% 5 Missing and 4 partials ⚠️
imports/api/publication/stats/frequencyBySex.ts 86.66% 5 Missing and 3 partials ⚠️
imports/api/publication/subscribe.ts 79.48% 3 Missing and 5 partials ⚠️
imports/api/publication/subscriptionInternals.ts 53.33% 7 Missing ⚠️
imports/ui/merge/useMergeInfo.ts 0.00% 7 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   66.27%   70.81%   +4.54%     
==========================================
  Files         719      763      +44     
  Lines       10006    11579    +1573     
  Branches     1349     1446      +97     
==========================================
+ Hits         6631     8200    +1569     
+ Misses       2915     2886      -29     
- Partials      460      493      +33     
Flag Coverage Δ
client 52.27% <78.79%> (+6.42%) ⬆️
server 60.54% <50.03%> (-2.07%) ⬇️
test 77.10% <88.50%> (+4.56%) ⬆️
test-app 55.38% <67.97%> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from bcb35f7 to 56ccada Compare July 23, 2024 12:27
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 6f1cce7 to e1efaa6 Compare July 24, 2024 06:14
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 18763d1 to 1aa42bc Compare July 26, 2024 22:45
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 1aa42bc to 46508ff Compare July 27, 2024 12:47
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 46508ff to 3e41278 Compare July 27, 2024 12:52
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 4bd28b1 to 6ba96b8 Compare December 9, 2024 21:42
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 6ba96b8 to 9d16559 Compare December 10, 2024 13:05
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 7132f98 to 7e6a6cc Compare December 10, 2024 20:59
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 7e6a6cc to e87c5cb Compare December 10, 2024 21:07
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from e87c5cb to 55eb33a Compare December 10, 2024 21:08
Reset in-book number loading state when disabled.
By leveraging new generic hook `useQuery`.
To minimize server refreshes when developing.
By leveraging new generic hook `useQuery`.
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch from 59b7fdc to aa8dff8 Compare January 2, 2025 14:44
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review January 2, 2025 14:47
@make-github-pseudonymous-again make-github-pseudonymous-again added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit e5a72ad Jan 2, 2025
35 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the refactor-use-change-streams-in-make-observed-query-publication-1-draft branch January 2, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drop-meteor This has to do with replacing the Meteor framework with something else feature/search This issue is about searching the data in general mongodb This has to do with MongoDB. research This needs some research.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

deathdate bugs
1 participant