-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed the entire node build into the final image #852
base: main
Are you sure you want to change the base?
Embed the entire node build into the final image #852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 65.86% 65.86%
=======================================
Files 715 715
Lines 9893 9893
Branches 1346 1346
=======================================
Hits 6516 6516
Misses 2919 2919
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6e21bb6
to
4fcf15c
Compare
4fcf15c
to
56d297b
Compare
Also, followed https://guide.meteor.com/using-node-v14.21.4#installing-node-in-linux for the proper way of defining |
56d297b
to
4b8fd63
Compare
4b8fd63
to
4221232
Compare
4221232
to
98de8fe
Compare
Not sure if this is necessary. Requires some research on the proper way of installing Node.js. Even if we have to include the
lib
andinclude
directories, it would only add ~40MB to the image. Compare this to ~80MB forbin
which is already included.