Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HEALTHCHECK for Dockerfile #855

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Implement HEALTHCHECK for Dockerfile #855

merged 5 commits into from
Apr 15, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented Apr 8, 2024 •
edited
Loading

@make-github-pseudonymous-again make-github-pseudonymous-again added deploy This issue is about deployment docker This has to do with docker images and containers dx This is about developer experience labels Apr 8, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.47%. Comparing base (810ca51) to head (76223bc).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         703      703           
  Lines        9705     9705           
  Branches     1335     1335           
=======================================
  Hits         6257     6257           
  Misses       3003     3003           
  Partials      445      445
Flag Coverage Δ
test 69.74% <ø> (-0.02%) ⬇️
test-app 53.76% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again
Copy link
Contributor Author

See docker/cli#4486 for the CI error.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review April 14, 2024 22:42
@make-github-pseudonymous-again make-github-pseudonymous-again removed this pull request from the merge queue due to a manual request Apr 14, 2024
Merged via the queue into main with commit 5aecfb7 Apr 15, 2024
16 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the dockerfile-add-healthcheck-1 branch April 15, 2024 00:52
@make-github-pseudonymous-again
Copy link
Contributor Author

See docker/cli#4486 for the CI error.

Works with buildx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy This issue is about deployment docker This has to do with docker images and containers dx This is about developer experience
Projects
None yet
Milestone
No milestone
1 participant
@make-github-pseudonymous-again