Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always refer to commit-sha-tagged image in ci:build:image #858

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented Apr 8, 2024

Two alternatives:

  • IMAGE_URL="$(echo "${IMAGE_METADATA}" | jq -r 'first(.tags[] | select(test(":sha-[0-9a-f]{40}$")))')"
  • IMAGE_URL="ghcr.io/${{ github.repository }}:sha-${{ github.sha }}"

See docker/metadata-action#164.

@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration dx This is about developer experience labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.45%. Comparing base (9bb8914) to head (17e423f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   64.45%   64.45%           
=======================================
  Files         703      703           
  Lines        9705     9705           
  Branches     1335     1335           
=======================================
  Hits         6255     6255           
+ Misses       3004     3003    -1     
- Partials      446      447    +1     
Flag Coverage Δ
test 69.74% <ø> (ø)
test-app 53.75% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review April 20, 2024 13:14
Merged via the queue into main with commit 94e543e Apr 20, 2024
21 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the ci-build-image-test-sha-1 branch May 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This issue is about continuous integration dx This is about developer experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant