Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease CI failure rate by tweaking timeouts in ci:test:deploy and ci:build:compose #953

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented May 14, 2024

Related to #900.

We have to wait for the build to succeed to test it, and the build
workflow might be sitting in the queue for a long time before it
actually start running when a lot of concurrent workflows are running.
Hence we increase the timeout to decrease timeout failure rates.
We have to wait for the build to succeed to leverage the cache the
resulting updated cache. The build workflow might be sitting in the
queue for a long time before it actually start running when a lot of
concurrent workflows are running. Hence we increase the timeout to
decrease timeout failure rates.
…che.

Instead of waiting forever on the build to succeed, we build it from a
potentially stale cache.
@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration dx This is about developer experience docker This has to do with docker images and containers labels May 14, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review May 14, 2024 21:46
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (52836ad) to head (a412b33).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   65.88%   65.86%   -0.03%     
==========================================
  Files         715      715              
  Lines        9893     9893              
  Branches     1346     1346              
==========================================
- Hits         6518     6516       -2     
- Misses       2918     2919       +1     
- Partials      457      458       +1     
Flag Coverage Δ
test 72.12% <ø> (-0.04%) ⬇️
test-app 53.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 922b7f6 May 14, 2024
23 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the ci-decrease-failure-rate-by-tweaking-timeouts-1 branch May 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This issue is about continuous integration docker This has to do with docker images and containers dx This is about developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant