Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test rate limiter #976

Merged
merged 10 commits into from
May 21, 2024
Merged

Test rate limiter #976

merged 10 commits into from
May 21, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Fixes #966.

@make-github-pseudonymous-again make-github-pseudonymous-again added testing This issue is about testing. security This issue is about the overall security of the application deps This issue has to do with dependencies dx This is about developer experience labels May 21, 2024
@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.06542% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.29%. Comparing base (d38cc05) to head (b9f0b3e).

Files Patch % Lines
server/api/rateLimit.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   65.89%   66.29%   +0.39%     
==========================================
  Files         715      717       +2     
  Lines        9893    10001     +108     
  Branches     1346     1349       +3     
==========================================
+ Hits         6519     6630     +111     
+ Misses       2917     2914       -3     
  Partials      457      457
Flag Coverage Δ
client 45.85% <9.34%> (-0.39%) ⬇️
server 62.59% <99.06%> (+0.68%) ⬆️
test 72.54% <99.05%> (+0.54%) ⬆️
test-app 53.73% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review May 21, 2024 14:55
Merged via the queue into main with commit 20ae46e May 21, 2024
33 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the test-rate-limiter-1 branch May 21, 2024 18:34
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deps This issue has to do with dependencies dx This is about developer experience security This issue is about the overall security of the application testing This issue is about testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write regression test for usage of rate-limiter-flexible
1 participant
@make-github-pseudonymous-again