-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(scripts): add some python scripts #2438
base: main
Are you sure you want to change the base?
Conversation
unit-test-results 79 files ±0 109 suites ±0 2m 4s ⏱️ -6s Results for commit 3497bba. ± Comparison against base commit 3b6e350. This pull request removes 12 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
============================================
+ Coverage 52.95% 54.62% +1.66%
- Complexity 3274 3360 +86
============================================
Files 991 1000 +9
Lines 22519 22746 +227
Branches 1750 1777 +27
============================================
+ Hits 11926 12426 +500
+ Misses 9694 9406 -288
- Partials 899 914 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added a python scripts location, and dependency version checking scripts.
Add scripts to retrieve information about the podiumd version, used component versions and compare them to another podiumd version.
9da677d
to
df6229b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe add a simple readme to tell developers which script to run for what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is probably good to add a readme.md in this folder explaining what these scripts do and how to use them (high level)?
Additionally we could also link to this folder from our existing updatingDependencies.md
doc?
scripts/python/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing but I would probably rename this folder from python
to something more meaningful like check-dependencies
? it is quite irrelevant that these scripts are written in Python no? It's more what they do I think. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can be other python scripts... so this could setup a common python environment, and from there run the scripts you need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarvonk can you please check the init-pyenv script again, it should work a bit better for you now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chore: add python scripts for version retrieval
To make it easier to find versions for individual components and for those used in a podiumd.
Solves: PZ-5197