Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add defaults for SMTP user and password #2535

Merged
merged 23 commits into from
Jan 29, 2025

Conversation

hsiliev
Copy link
Collaborator

@hsiliev hsiliev commented Jan 27, 2025

Allow start of Wildfly without SMTP user and password environment variables

Solves PZ-4748

Hristo Iliev added 2 commits January 27, 2025 12:19
Copy link
Contributor

github-actions bot commented Jan 27, 2025

unit-test-results

 79 files  ±0  110 suites  ±0   1m 31s ⏱️ ±0s
381 tests ±0  380 ✅ ±0  1 💤 ±0  0 ❌ ±0 
475 runs  ±0  473 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 35cea5a. ± Comparison against base commit e87d02f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 27, 2025

integration-test-results

 28 files  ±0   28 suites  ±0   35s ⏱️ ±0s
107 tests ±0  107 ✅ ±0  0 💤 ±0  0 ❌ ±0 
120 runs  ±0  120 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35cea5a. ± Comparison against base commit e87d02f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.76%. Comparing base (e87d02f) to head (35cea5a).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/main/kotlin/net/atos/zac/mail/MailService.kt 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2535    +/-   ##
==========================================
  Coverage     54.76%   54.76%            
- Complexity     3366     3367     +1     
==========================================
  Files          1004     1004            
  Lines         22761    22768     +7     
  Branches       1785     1751    -34     
==========================================
+ Hits          12465    12469     +4     
- Misses         9382     9503   +121     
+ Partials        914      796   -118     
Flag Coverage Δ
integrationtests 50.04% <42.85%> (-0.01%) ⬇️
unittests 34.84% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@hsiliev hsiliev changed the title feature: add defaults for SMTP configuration feature: add defaults for SMTP user and password Jan 27, 2025
src/main/kotlin/net/atos/zac/mail/MailService.kt Outdated Show resolved Hide resolved
@hsiliev hsiliev marked this pull request as ready for review January 28, 2025 20:53
@hsiliev hsiliev requested a review from a team as a code owner January 28, 2025 20:53
src/main/resources/wildfly/configure-wildfly.cli Outdated Show resolved Hide resolved
.env.tpl Show resolved Hide resolved
.env.tpl Show resolved Hide resolved
@hsiliev hsiliev added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 47b6a4f Jan 29, 2025
24 checks passed
@hsiliev hsiliev deleted the fix/PZ-4748-optional-mailserver-configuration branch January 29, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants