-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): reshuffled zaak detail card layout #2542
Merged
xiduzo
merged 5 commits into
main
from
feat/PZ-4895--FE--zaak-details-card-layout-changes
Jan 28, 2025
Merged
feat(app): reshuffled zaak detail card layout #2542
xiduzo
merged 5 commits into
main
from
feat/PZ-4895--FE--zaak-details-card-layout-changes
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
============================================
+ Coverage 53.78% 54.62% +0.84%
- Complexity 3283 3360 +77
============================================
Files 1000 1000
Lines 22730 22746 +16
Branches 1775 1750 -25
============================================
+ Hits 12225 12426 +201
+ Misses 9610 9525 -85
+ Partials 895 795 -100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiduzo
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE - reshuffled zaak detail card layout according to design
turns out components behave quite different. When editing the zaak details moves to the sidebar form, there is just one component needed to show field values, the
taak view detail used the Group/Medewerker component as well; so Taak Detail page also updated
time boxed the time put into pixelating, but some viewport widths 1 field is a bit off; as mentioned, easy to fix when all has become one component type
Solves PZ-4859