Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): reshuffled zaak detail card layout #2542

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

infonl-marcel
Copy link
Contributor

@infonl-marcel infonl-marcel commented Jan 27, 2025

FE - reshuffled zaak detail card layout according to design

  • turns out components behave quite different. When editing the zaak details moves to the sidebar form, there is just one component needed to show field values, the

  • taak view detail used the Group/Medewerker component as well; so Taak Detail page also updated

  • time boxed the time put into pixelating, but some viewport widths 1 field is a bit off; as mentioned, easy to fix when all has become one component type

Solves PZ-4859

@infonl-marcel infonl-marcel changed the title feat(app): --DRAFT-- reshuffled zaak detail card layout feat(app): reshuffled zaak detail card layout Jan 28, 2025
Copy link
Contributor

unit-test-results

 79 files  ±0  109 suites  ±0   1m 59s ⏱️ -9s
378 tests ±0  377 ✅ ±0  1 💤 ±0  0 ❌ ±0 
472 runs  ±0  470 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 9755cde. ± Comparison against base commit 75ad00e.

Copy link
Contributor

integration-test-results

 28 files  ±0   28 suites  ±0   36s ⏱️ ±0s
107 tests ±0  107 ✅ ±0  0 💤 ±0  0 ❌ ±0 
120 runs  ±0  120 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9755cde. ± Comparison against base commit 75ad00e.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (e2a4113) to head (9755cde).
Report is 51 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2542      +/-   ##
============================================
+ Coverage     53.78%   54.62%   +0.84%     
- Complexity     3283     3360      +77     
============================================
  Files          1000     1000              
  Lines         22730    22746      +16     
  Branches       1775     1750      -25     
============================================
+ Hits          12225    12426     +201     
+ Misses         9610     9525      -85     
+ Partials        895      795     -100     
Flag Coverage Δ
integrationtests 50.00% <ø> (+0.82%) ⬆️
unittests 34.69% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@infonl-marcel infonl-marcel marked this pull request as ready for review January 28, 2025 14:41
@infonl-marcel infonl-marcel requested review from hsiliev and a team as code owners January 28, 2025 14:41
@xiduzo xiduzo added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit e87d02f Jan 28, 2025
24 checks passed
@xiduzo xiduzo deleted the feat/PZ-4895--FE--zaak-details-card-layout-changes branch January 28, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants