fix: zaak geometry should not be deleted on zaak update #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 2319 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2021 | 1 | 297 | 0 |
Click to see the invalid file list
- src/main/java/net/atos/client/zgw/zrc/model/GeometryToBeDeleted.kt
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
============================================
+ Coverage 54.77% 54.81% +0.04%
- Complexity 3365 3372 +7
============================================
Files 1002 1003 +1
Lines 22747 22762 +15
Branches 1771 1777 +6
============================================
+ Hits 12459 12478 +19
- Misses 9376 9490 +114
+ Partials 912 794 -118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…es (where the zaakgeometrie is not updated); work in progress
… custom JSONB serializer for geometry objects that can dynamically either set or delete a geometry in a zaak patch request
… custom JSONB serializer for geometry objects that can dynamically either set or delete a geometry in a zaak patch request
…d.kt Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
edgarvonk
force-pushed
the
feature/fix-zaak-geometry-deleted-on-zaak-update
branch
from
e473395 to
0eb7c84
Compare
hsiliev
reviewed
Feb 3, 2025
src/test/kotlin/nl/info/client/zgw/zrc/jsonb/GeometryJsonbSerializerTest.kt
Outdated
Show resolved
Hide resolved
hsiliev
approved these changes
Feb 3, 2025
…alizerTest.kt Co-authored-by: Hristo Iliev <[email protected]>
edgarvonk
deleted the
feature/fix-zaak-geometry-deleted-on-zaak-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where zaak geometry was deleted on every zaak update and fixed issue where zaak geometry update and deletions sometimes worked and sometimes did not. The issue was that for deletions a @JsonbNillable annotation was used on the Zaak object in the ZrcClient but for normal updates not. However this annotation is static and there is only one zaak patch method in the ZrcClient and this resulted in inconsistent behaviour. This was solved by introducing a custom JSONB serializer for the zaak Geometry class that dynamically either writes a null (for deletions) or the geometry (Point only for now) object to JSON.
Solves PZ-5299