Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): sync withibc dependency bumps #5

Merged
merged 15 commits into from
Nov 15, 2024
Merged

chore(deps): sync withibc dependency bumps #5

merged 15 commits into from
Nov 15, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Nov 8, 2024 •
edited
Loading

@rnbguy rnbguy marked this pull request as ready for review November 12, 2024 12:49
Farhad-Shabani
Farhad-Shabani reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. Let's treat ibc as an external dependency. Merge this PR once the next version of ibc is released, so we can list it as a breaking change in the change log.

Farhad-Shabani
Farhad-Shabani approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 4a19b80 Nov 15, 2024
7 checks passed
@Farhad-Shabani Farhad-Shabani deleted the rano/ibc-rs-sync branch November 15, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Farhad-Shabani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnbguy @Farhad-Shabani