feat: quartz-common and merging quartz-cli business logic from cycles-protocol #123
Conversation
dangush
force-pushed
the
dangush/rust-scripts
branch
from
986f27f to
4c61d69
Compare
dangush
force-pushed
the
dangush/rust-scripts
branch
from
4c61d69 to
afc41f3
Compare
There was a problem hiding this comment.
I haven't been able to run any of this code yet, so I can't verify that it works, but for time's sake I'd suggest we merge this and make any necessary fixes in follow-up PRs.
There's still a lot of work here to get to the point that we have the cycles-quartz repo in a good state and we have our quartz CLI working as per #61.
I'd still like to hear a good argument against the idea of having a single crates directory in which every crate that we make available as a library is kept. If there isn't one, let's get that done in a follow-up PR ASAP.
We also need to get rid of apps/mtcs from this repo ASAP.
There was a problem hiding this comment.
Awesome work @dangush! Did a quick review and didn't test but added some minor comments. Also the comments from #87 are still applicable because AFAICT this PR includes those changes too. Agree with Thane we should merge this quick, so I'm fine with merging this without addressing my comments but would be nice to address them in future PRs. 🙏
| impl std::cmp::Ord for LiquiditySource { | ||
| fn cmp(&self, other: &Self) -> Ordering { | ||
| self.address.cmp(&other.address) | ||
| } | ||
| } | ||
|
|
||
| impl PartialOrd for LiquiditySource { | ||
| fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | ||
| Some(self.address.cmp(&other.address)) | ||
| } | ||
| } | ||
|
|
||
| // PartialEq implemented in #[cw_serde] | ||
| impl Eq for LiquiditySource {} |
dangush
changed the title
Merges the quartz cli rust scripts, changes to quartz packages, and changes to mtcs app (so basically the entirety of
cycles-protocolintocycles-quartz.This merge precedes the removal of all
quartzpackages from thecycles-protocolrepo.