Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mtcs sends messages to overdraft contract #67

Closed
wants to merge 9 commits into from

Conversation

dangush
Copy link
Contributor

@dangush dangush commented Jun 28, 2024

Working on integrating MTCS and overdrafts so that transfers are reflected as balance changes in the mtcs-overdraft contract.

Closes informalsystems/cycles-protocol#38


This PR is completed and ready for review when it is:

  • Merged with Peppi's escrow contracts branch to ensure compatibility

TODO

Short Term

  • Fix listening script to query correct epoch-indexed storage keys
  • Write a script for deploying and instantiating the overdraft + membership contracts
  • Remove overdrafts contract from contract state <- decide where granting mtcs ownership over liquidity sources gets handled
  • Align code changes with Peppi's escrow PR and merge the two
  • Add setter for overdraft owner so that MTCS can be added post-instantiation
  • Working overdrafts clearing with MTCS
  • understand what causes the sequence mismatch error and make sure it doesn't show up again

Blocked / questions

  • working message attestations
  • Handle setoffs correctly according to persistence
    • In $ -> Alice -> Bob -> $ scenario, what should happen with the Alice -> Bob setoff notice?
    • The A -> B obligation needs to be updated before persisted to the next epoch.
    • Blocked on "epoch persistence"
  • Clean up the rust script for generating encrypted obligations. What should the final form of this look like?

Long Term

  • Rewrite memberships contract to better suit our needs (replace member vec with map, remove 'weights')

@hu55a1n1
Copy link
Member

@dangush Is this PR superseded by the work currently on the cycles-protocol repo (main branch)? If so can we close this?

@hu55a1n1
Copy link
Member

Closing because the MTCS app work is now happening on the cycles-protocol repo. (And this should already be on main there)

@hu55a1n1 hu55a1n1 closed this Jul 17, 2024
@dangush dangush deleted the dangush/mtcs-overdraft-interop branch July 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants