refactor: decouple mtcs_server from quartz #27
clippy
35 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 35 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 320 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:320:28
|
320 | println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 310 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:310:22
|
310 | let sk = XPrv::from_str(&sk_str).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 307 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:307:28
|
307 | println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 298 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:298:26
|
298 | let setoff = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 296 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:296:30
|
296 | let ciphertext = hex::decode(setoff).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 276 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:276:17
|
276 | d.try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 320 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:320:28
|
320 | println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 310 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:310:22
|
310 | let sk = XPrv::from_str(&sk_str).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 307 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:307:28
|
307 | println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 298 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:298:26
|
298 | let setoff = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 296 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:296:30
|
296 | let ciphertext = hex::decode(setoff).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 276 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:276:17
|
276 | d.try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 255 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:255:25
|
255 | let o = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 252 in utils/mtcs-intent/src/main.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> utils/mtcs-intent/src/main.rs:252:30
|
252 | let ciphertext = hex::decode(obligation).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> utils/mtcs-intent/src/main.rs:6:5
|
6 | clippy::unwrap_used,
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 380 in utils/cycles-sync/src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> utils/cycles-sync/src/main.rs:380:41
|
380 | let mnemonic = Mnemonic::random(&mut OsRng, Default::default());
| ^^^^^^^^^^ help: change this to: `OsRng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 117 in utils/cycles-sync/src/main.rs
github-actions / clippy
you are explicitly cloning with `.map()`
warning: you are explicitly cloning with `.map()`
--> utils/cycles-sync/src/main.rs:115:48
|
115 | let (debtor_id, creditor_id) = obligation_user_map
| ________________________________________________^
116 | | .get(obligation_digest)
117 | | .map(Clone::clone)
| |______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `copied` method
|
115 ~ let (debtor_id, creditor_id) = obligation_user_map
116 + .get(obligation_digest).copied()
|
Check warning on line 117 in utils/cycles-sync/src/main.rs
github-actions / clippy
you are explicitly cloning with `.map()`
warning: you are explicitly cloning with `.map()`
--> utils/cycles-sync/src/main.rs:115:48
|
115 | let (debtor_id, creditor_id) = obligation_user_map
| ________________________________________________^
116 | | .get(obligation_digest)
117 | | .map(Clone::clone)
| |______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `copied` method
|
115 ~ let (debtor_id, creditor_id) = obligation_user_map
116 + .get(obligation_digest).copied()
|
Check warning on line 180 in core/quartz/src/server.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> core/quartz/src/server.rs:180:1
|
180 | pub struct ProofOfPublication {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 52 in core/quartz/src/server.rs
github-actions / clippy
missing documentation for an associated function
warning: missing documentation for an associated function
--> core/quartz/src/server.rs:52:5
|
52 | pub fn new(config: Config, sk: Arc<Mutex<Option<SigningKey>>>, attestor: A) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 41 in core/quartz/src/server.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> core/quartz/src/server.rs:41:1
|
41 | pub struct CoreService<A> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 12 in core/quartz/src/prost/mtcs.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> core/quartz/src/prost/mtcs.rs:12:5
|
12 | pub message: ::prost::alloc::string::String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 10 in core/quartz/src/prost/mtcs.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> core/quartz/src/prost/mtcs.rs:10:1
|
10 | pub struct RunClearingResponse {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 6 in core/quartz/src/prost/mtcs.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> core/quartz/src/prost/mtcs.rs:6:5
|
6 | pub message: ::prost::alloc::string::String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 4 in core/quartz/src/prost/mtcs.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> core/quartz/src/prost/mtcs.rs:4:1
|
4 | pub struct RunClearingRequest {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 20 in core/quartz/src/cli.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> core/quartz/src/cli.rs:20:1
|
20 | pub struct Cli {
| ^^^^^^^^^^^^^^