Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generic query clients CLI #519

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Implement generic query clients CLI #519

merged 14 commits into from
Jan 14, 2025

Conversation

seanchen1991
Copy link
Contributor

Closes: #518

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 changed the title Implement genereic query clients CLI Implement generic query clients CLI Jan 8, 2025
@seanchen1991 seanchen1991 marked this pull request as ready for review January 13, 2025 17:22
@seanchen1991 seanchen1991 merged commit ffa680b into main Jan 14, 2025
10 checks passed
@seanchen1991 seanchen1991 deleted the sean/generic-query-clients-cli branch January 14, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement generic query clients CLI
2 participants
@seanchen1991 @soareschen