Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple connection hops in tx chan-open-ack #4049

Closed
7 of 11 tasks
Tracked by #3940 ...
joaotav opened this issue Jun 19, 2024 · 1 comment
Closed
7 of 11 tasks
Tracked by #3940 ...

Add support for multiple connection hops in tx chan-open-ack #4049

joaotav opened this issue Jun 19, 2024 · 1 comment
Assignees
Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel

Comments

@joaotav
Copy link
Collaborator

joaotav commented Jun 19, 2024

Part of: #3940

Summary

tx chan-open-ack

  • Replace call to tx_chan_cmd! macro with an inline function on TxChanOpenAckCmd
  • Add build_multihop_chan_open_ack() to method build_chan_open_ack_and_send() to enable the construction of MsgChannelOpenAck messages when multiple connection hops have been specified.
  • Modify validated_expected_channel() to support channel ends with multiple connection hops on the destination chain.

Tests

  • Manual testing for single-hop channel handshake
  • Manual testing for multihop channel handshake with 2 connection hops
  • Manual testing for multihop channel handshake with 2+ connection hops

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@joaotav joaotav added the O: multi-hop Related to ICS 033 Multi-Hop Channel label Jun 19, 2024
@joaotav joaotav self-assigned this Jun 19, 2024
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 19, 2024
@romac
Copy link
Member

romac commented Jun 21, 2024

Done in #4050

@romac romac closed this as completed Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants