Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multihop support for tx chan-open-ack #4050

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

joaotav
Copy link
Collaborator

@joaotav joaotav commented Jun 20, 2024

Closes: #4049

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

* Replace call to `tx_chan_cmd!` macro with an inline function

* Add `build_multihop_chan_open_ack()`
@joaotav joaotav self-assigned this Jun 20, 2024
@joaotav joaotav added the O: multi-hop Related to ICS 033 Multi-Hop Channel label Jun 20, 2024
joaotav added 2 commits June 20, 2024 17:37
* Replace incorrect call to `build_chan_open_try()` with a call to
  `build_chan_open_ack()` within `do_build_chan_open_ack_and_send()`
  method
hops

* Add a more descriptive message to
  `ChannelError::UnexpectedChannelState`

* Improve comments
@joaotav joaotav marked this pull request as ready for review June 21, 2024 06:27
@joaotav joaotav requested a review from romac June 21, 2024 06:44
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@romac romac merged commit 1191665 into joaotav/multihop-poc Jun 21, 2024
31 checks passed
@romac romac deleted the joaotav/4049-tx-chan-open-ack branch June 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants