Add support for multiple connection hops in create channel command
#4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
* Add `--connection-hops` parameter to `CreateChannelCommand` * Add method `run_multihop_reusing_connection()` to struct `CreateChannelCommand` * Add associated function `new_multihop()` to struct `Channel`
joaotav
commented
Jun 28, 2024
| @@ -322,6 +323,9 @@ impl CreateChannelCommand { | |||
| ) { | |||
| let config = app_config(); | |||
|
|
|||
| // Set global registry to get or spawn chain handles | |||
| set_global_registry(SharedRegistry::new((*app_config()).clone())); | |||
There was a problem hiding this comment.
Even though the registry is being set here (as it is needed further down in the chain of function calls), the chains are being spawned using spawn_chain_runtime() rather than using get_or_spawn() within run_multihop_reusing_connection(). This was to keep it consistent with run_reusing_connection() which was already implemented and uses spawn_chain_runtime().
As get_or_spawn() might give us some performance, if we decide to keep using the registry in the CLIs we should use it here and make it consistent across all methods.
There was a problem hiding this comment.
Good catch! Yeah let's see by the end of the implementation phase which technique we want to go with.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4062
Description
create channelcommand #4062PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.