Allow tributes for proposals in past rounds #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
LGTM!
Do you think it would be useful to add info to each Tribute that would say in which round the tribute was added? The motivation would be: if someone wants to mess around with tributes for some proposal, this way we could at least know if some tribute was added before or after the voting was finished. WDYT?
|
Hm, it's not a bad idea. It might be even more helpful to keep an exact "creation time" timestamp though; that could help with showing graphs of how the tribute evolved over time, if we ever need that |
|
and of course of we already do that, we might as well keep the round the tributes were created in, too. I will add both |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a tribute, the round id is now an input parameter, instead of computed from the current time.
This means that tribute can even be added for tributes in past rounds (before, the round id being automatically computed would cause the prop not to be queried from the store)