Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a migration to push the start date to be later #156

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

p-offtermatt
Copy link
Member

Description

Closes: N/A

Add a description of the changes that this PR introduces and the files that
are the most critical to review.

Adds a migration to push the start date to be later.
Concretely:
the migrate message will contain the new first round start date.
The contract will simply set its start date to that date, and set the end of all existing locks to the end of the new first round.

The migration has a bunch of checks to make sure its assumptions are correct:

  • it only works while the contract is in its first round
  • it only works if the new first round end is in the future

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • [o] Added/adjusted the necessary interchain tests
  • [o] Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

@p-offtermatt p-offtermatt requested a review from a team as a code owner October 21, 2024 09:31
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog, otherwise good.

@p-offtermatt p-offtermatt merged commit 3a4ab00 into main Oct 22, 2024
5 checks passed
@p-offtermatt p-offtermatt deleted the ph/migrate-start branch October 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants