Implement and test update client methods on relay context (#107)

* Implement CanQueryConsensusStateHeight for StarknetChain

* Implement CanSendTargetUpdateClientMessage to Starknet

* Use relay.send_target_update_client_messages in test

* Test full relaying of UpdateClient on both sides

* Wire up CosmosToStarknetRelay

* Update branch

* Use back main branch

relayer/crates/starknet-chain-components/src/components/chain.rs

@@ -1,6 +1,8 @@
 use cgp::core::component::WithProvider;
 use cgp::core::types::impls::UseDelegatedType;
 use cgp::prelude::*;
+use hermes_chain_components::impls::queries::consensus_state_height::QueryConsensusStateHeightsAndFindHeightBefore;
+use hermes_chain_components::impls::queries::consensus_state_heights::QueryLatestConsensusStateHeightAsHeights;
 pub use hermes_cosmos_chain_components::components::client::*;
 use hermes_cosmos_chain_components::impls::packet::packet_fields::CosmosPacketFieldReader;
 use hermes_cosmos_chain_components::impls::types::chain::ProvideCosmosChainTypes;
@@ -198,6 +200,10 @@ define_components! {
             QueryCometClientState,
         ConsensusStateQuerierComponent:
             QueryCometConsensusState,
+        ConsensusStateHeightQuerierComponent:
+            QueryConsensusStateHeightsAndFindHeightBefore,
+        ConsensusStateHeightsQuerierComponent:
+            QueryLatestConsensusStateHeightAsHeights,
         ContractAddressQuerierComponent:
             GetContractAddressFromField,
     }

relayer/crates/starknet-chain-components/src/impls/queries/consensus_state.rs

@@ -22,6 +22,12 @@ use crate::types::client_id::ClientId;
 use crate::types::cosmos::consensus_state::CometConsensusState;
 use crate::types::cosmos::height::Height;
 
+#[derive(Debug)]
+pub struct ConsensusStateNotFound {
+    pub client_id: ClientId,
+    pub height: Height,
+}
+
 pub struct QueryCometConsensusState;
 
 impl<Chain, Counterparty, Encoding> ConsensusStateQuerier<Chain, Counterparty>
@@ -34,6 +40,7 @@ where
         + HasBlobType<Blob = Vec<Felt>>
         + HasEncoding<AsFelt, Encoding = Encoding>
         + CanQueryContractAddress<symbol!("ibc_client_contract_address")>
+        + CanRaiseError<ConsensusStateNotFound>
         + CanRaiseError<Encoding::Error>,
     Counterparty:
         HasConsensusStateType<Chain, ConsensusState = CometConsensusState> + HasHeightFields,
@@ -45,22 +52,21 @@ where
     async fn query_consensus_state(
         chain: &Chain,
         _tag: PhantomData<Counterparty>,
-        client_id: &Chain::ClientId,
+        client_id: &ClientId,
         consensus_height: &Counterparty::Height,
         _query_height: &Chain::Height, // TODO: figure whether we can perform height specific queries on Starknet
     ) -> Result<Counterparty::ConsensusState, Chain::Error> {
         let encoding = chain.encoding();
 
         let contract_address = chain.query_contract_address(PhantomData).await?;
 
+        let height = Height {
+            revision_number: Counterparty::revision_number(consensus_height),
+            revision_height: Counterparty::revision_height(consensus_height),
+        };
+
         let calldata = encoding
-            .encode(&(
-                client_id.sequence,
-                Height {
-                    revision_number: Counterparty::revision_number(consensus_height),
-                    revision_height: Counterparty::revision_height(consensus_height),
-                },
-            ))
+            .encode(&(client_id.sequence, height.clone()))
             .map_err(Chain::raise_error)?;
 
         let output = chain
@@ -74,6 +80,15 @@ where
             .decode(&raw_consensus_state)
             .map_err(Chain::raise_error)?;
 
+        // FIXME: Temporary workaround, as the current Cairo contract returns
+        // default value when the entry is not found.
+        if consensus_state.root.is_empty() {
+            return Err(Chain::raise_error(ConsensusStateNotFound {
+                client_id: client_id.clone(),
+                height,
+            }));
+        }
+
         Ok(consensus_state)
     }
 }

relayer/crates/starknet-chain-components/src/impls/starknet_to_cosmos/update_client_payload.rs

@@ -19,6 +19,14 @@ use crate::types::cosmos::update::CometUpdateHeader;
 
 pub struct BuildUpdateCometClientPayload;
 
+/*
+   Stub implementation of UpdateClient payload builder from Cosmos to Starknet.
+   We basically build a `CosmosCreateClientPayload`, and then use the state root
+   of the consensus state to build a dummy update header.
+
+   TODO: refactor Cosmos UpdateClient header so that they are more easily
+   be converted into the Cairo encoding for the Starknet Comet contract.
+*/
 impl<Chain, Counterparty> UpdateClientPayloadBuilder<Chain, Counterparty>
     for BuildUpdateCometClientPayload
 where
@@ -33,6 +41,7 @@ where
     async fn build_update_client_payload(
         chain: &Chain,
         trusted_height: &CosmosHeight,
+        // Ignore the target height for the dummy implementation
         _target_height: &CosmosHeight,
         _client_state: Chain::ClientState,
     ) -> Result<CometUpdateHeader, Chain::Error> {