test(e2e): submit ics20 packets to ibc-core contract on starknet #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soareschen I am thinking to perform proper connection and channel handshakes at starknet using ibc-core cairo contract (#129 introduces ibc-core cairo contract in e2e tests). does this sound alright with you ? |
soareschen
approved these changes
Dec 10, 2024
rnbguy
force-pushed
the
rano/ics20-relay
branch
from
cca17f6 to
c50b1f9
Compare
rnbguy
changed the title
|
@soareschen I changed the to-be-resolve issue for this PR as this doesn't really add the complete relay between cosmos to starknet. I will do that in my next PR modifiying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #125
Requires proper connection, channel handshake at cosmos side of ics20. So, we need ibc-core contract deployed at Starknet (#129) for the handshakes.{Conn,Chan}Open{Init,Ack}.on_recvics20 packet at ibc-core.