Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove inadvertently introduced old transfer contract #36

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: remove inadvertently introduced old transfer contract #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e7f209
fix: remove old transfer contract
Farhad-Shabani Jul 31, 2024
c7322ea
fix: CI paths
Farhad-Shabani Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cairo-contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: Cairo Contracts
on:
pull_request:
paths:
- .github/workflows/tests.yaml
- contracts/**
- .github/workflows/cairo-contracts.yaml
- cairo-contracts/**
- justfile

push:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/light-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ name: Light Client
on:
pull_request:
paths:
- .github/workflows/rust.yaml
- contracts/**
- .github/workflows/light-client.yaml
- light-client/**
- "**/Cargo.toml"
- "**/Cargo.lock"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
pull_request:
paths:
- .github/workflows/lint.yaml
- contracts/**
- cairo-contracts/**
- light-client/**
- "**/Cargo.toml"
- "**/Cargo.lock"
Expand Down
6 changes: 2 additions & 4 deletions cairo-contracts/src/apps/transfer/component.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@ pub mod ICS20TransferComponent {
use core::num::traits::Zero;
use core::option::OptionTrait;
use core::starknet::SyscallResultTrait;
use openzeppelin::utils::serde::SerializedAppend;
use starknet::ClassHash;
use starknet::ContractAddress;
use starknet::get_contract_address;
use starknet_ibc::apps::transfer::errors::TransferErrors;
use starknet_ibc::apps::transfer::interface::{ISendTransfer, IRecvPacket, ITokenAddress};
use starknet_ibc::apps::transfer::types::{
MsgTransfer, PrefixedDenom, Denom, DenomTrait, PacketData, TracePrefix, Memo,
TracePrefixTrait, ERC20TokenTrait, ERC20Token, MAXIMUM_MEMO_LENGTH, ValidateBasicTrait,
PrefixedDenomTrait
TracePrefixTrait, ERC20TokenTrait, ERC20Token, ValidateBasicTrait, PrefixedDenomTrait
};
use starknet_ibc::apps::transferrable::interface::ITransferrable;
use starknet_ibc::core::channel::types::Packet;
Expand Down Expand Up @@ -438,7 +436,7 @@ pub mod ICS20TransferComponent {
pub(crate) impl TransferEventImpl<
TContractState, +HasComponent<TContractState>, +Drop<TContractState>
> of TransferEventTrait<TContractState> {
fn emit_send_event(ref self: ComponentState<TContractState>, packet_date: PacketData,) {
fn emit_send_event(ref self: ComponentState<TContractState>, packet_date: PacketData) {
self
.emit(
SendEvent {
Expand Down
72 changes: 0 additions & 72 deletions cairo-contracts/src/contracts/transfer.cairo
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions cairo-contracts/src/core/types.cairo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion cairo-contracts/src/presets.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
mod erc20;
mod transfer;

#[cfg(test)]
pub use erc20::ERC20;
pub use transfer::Transfer;

Loading