-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: cairo/scarb structure suggestions #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the points you mentioned sound great!
Just as for { workspace = true }
, I kept it as-is to stay consistent with the other workspaces. Plus, I found it a bit cleaner to catch at a glance.
On the granular versioning side, since we're still early in development, we'll likely bump the version together for a while until things stabilize. But after, your suggestion definitely makes sense. I also got the meta starknet_ibc
package back in.
Only remained local component testing. I opened up #79 to tackle it as a separate effort.
Thanks again for the awesome suggestions and the PR! ✨
OK. I'M DOINT IT NOW. |
Structure:
.tool-versions
filePersonal Preferences:
.workspace = true
>= { workspace = true }
#[cfg(test)]
except formod mocks
in order to keep mocks segregated from business logic but still buildable via snforgeRecommendations: