Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Feature-gate metrics in malachitebft-core-consensus crate #681

Open
romac opened this issue Dec 13, 2024 · 0 comments · May be fixed by #762
Open

code: Feature-gate metrics in malachitebft-core-consensus crate #681

romac opened this issue Dec 13, 2024 · 0 comments · May be fixed by #762
Labels
code Code/implementation related good first issue Good for newcomers no_std no_std compatibility
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Dec 13, 2024 •
edited
Loading

The malachitebft-metrics crate is not no_std compatible and must therefore be feature-gated to not prevent no_std compatibility in the future.
@romac romac added the code Code/implementation related label Dec 13, 2024
@romac romac added this to the Phase 5 milestone Dec 13, 2024
@romac romac added no_std no_std compatibility good first issue Good for newcomers labels Dec 13, 2024
@romac romac changed the title code: Feature-gate metrics in malachite-consensus crate code: Feature-gate metrics in malachitebft-core-consensus crate Jan 13, 2025
@OakenKnight OakenKnight linked a pull request Jan 14, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code/implementation related good first issue Good for newcomers no_std no_std compatibility
Projects
None yet
Milestone
Phase 5
Development

Successfully merging a pull request may close this issue.

feat(code): Feature-gate metrics in core-consensus crate OakenKnight/malachite
1 participant
@romac