Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Feature-gate metrics in core-consensus crate #762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OakenKnight
Copy link
Member

Closes: #681

PR author checklist

For all contributors

For external contributors

@romac romac changed the title feat(code): Feature-gating malachitebft-metrics in malachitebft-core-consensus crate feat(code): Feature-gate metrics in core-consensus crate Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (d07ff16) to head (3a56d25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   79.27%   79.00%   -0.27%     
==========================================
  Files         104      104              
  Lines        9026     9034       +8     
==========================================
- Hits         7155     7137      -18     
- Misses       1871     1897      +26     
Flag Coverage Δ
integration 79.00% <100.00%> (+0.02%) ⬆️
mbt ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Feature-gate metrics in malachitebft-core-consensus crate
1 participant