-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(code): Store precommits and send to host if value is decided #234
Conversation
Send the commits with the decision to host.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 86.63% 86.81% +0.18%
==========================================
Files 59 59
Lines 4786 4805 +19
==========================================
+ Hits 4146 4171 +25
+ Misses 640 634 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Closes: #XXX
More significant changes are:
ReceivedBlock
with Proposal fully in the consensus actorTODO in a subsequent PR
- [ ] Value builder uses the commits (together with the block parts) to build and storePR author checklist