Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Store precommits and send to host if value is decided #234

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Jun 13, 2024

Closes: #XXX

More significant changes are:

  • Move the multiplexing of ReceivedBlock with Proposal fully in the consensus actor
  • Store the received blocks in the consensus actor (instead of driver)
  • Store the precommits in consensus actor
  • Consensus to add the precommits to the decision from driver and send to host
  • Host sends the commits to value builder

TODO in a subsequent PR
- [ ] Value builder uses the commits (together with the block parts) to build and store


PR author checklist

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (6f8ccd0) to head (5608005).

Files Patch % Lines
code/crates/actors/src/consensus.rs 98.36% 1 Missing ⚠️
code/crates/test-app/src/value_builder.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   86.63%   86.81%   +0.18%     
==========================================
  Files          59       59              
  Lines        4786     4805      +19     
==========================================
+ Hits         4146     4171      +25     
+ Misses        640      634       -6     
Flag Coverage Δ
integration 86.87% <97.06%> (+0.18%) ⬆️
mbt 17.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ancazamfir ancazamfir requested review from romac and greg-szabo June 13, 2024 13:25
@romac romac marked this pull request as ready for review June 13, 2024 14:07
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

code/crates/actors/src/consensus.rs Outdated Show resolved Hide resolved
@romac romac merged commit 0da7de2 into main Jun 13, 2024
12 checks passed
@romac romac deleted the anca/block_proposal_mux_cleanup branch June 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants