Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): add timeout to Blocksync #568

Merged
merged 11 commits into from
Nov 20, 2024
Merged

Conversation

josef-widder
Copy link
Member

@josef-widder josef-widder commented Nov 18, 2024

Closes: #567

Once #561 is merged, we should add timeout actions to all the statemachines. Or better: we merge this first, and then do all the wiring of the new action in #561 .


PR author checklist

@josef-widder josef-widder requested a review from cason November 18, 2024 15:34
@josef-widder josef-widder marked this pull request as ready for review November 18, 2024 15:54
Copy link
Contributor

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the tabulation once #564 is merged.

Moreover, we need to use the client's action in the generic state machine.

specs/quint/specs/blocksync/client.qnt Outdated Show resolved Hide resolved
specs/quint/specs/blocksync/client.qnt Outdated Show resolved Hide resolved
Copy link
Contributor

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@josef-widder josef-widder merged commit efa36c7 into main Nov 20, 2024
13 checks passed
@josef-widder josef-widder deleted the josef/i559-blocksynctimeout branch November 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec: Add timeout action to the blocksync client
2 participants