refactor(spec): new structure for the specs/ directory
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cason
added
work in progress
4 tasks
This reverts commit a5e6a7b.
cason
commented
Nov 25, 2024
| .then(reset) | ||
| .then(addL1BlockProofWithHeight(1,1)) | ||
| .expect(L2[L2.length()-1] == L1[L1.length()-1].latestProvenL2BlockHash) | ||
| //// TODO: fix those tests, see https://github.com/informalsystems/malachite/issues/610. |
There was a problem hiding this comment.
Associated issue: #610
cason
commented
Nov 25, 2024
| @@ -4,7 +4,7 @@ pub fn generate_test_traces(spec_rel_path: &str, gen_dir: &str, quint_seed: u64) | |||
| println!("🪄 Generating test traces for {spec_rel_path:?}..."); | |||
|
|
|||
| let spec_abs_path = format!( | |||
| "{}/../../../../specs/quint/{spec_rel_path}", | |||
| "{}/../../../../specs/consensus/quint/{spec_rel_path}", | |||
There was a problem hiding this comment.
This should not be hardcoded in this way, I'd say.
cason
changed the title
specs/ directory (WIP)specs/ directory
romac
approved these changes
Nov 27, 2024
#623) * spec: consensus README.md updated * spec/consensus: README re-organized * spec/consensu: added design.md document, empty by now * spec/consensus: removed empty design.md * spec: new design.md file from existing English spec * spec/consensus: design introduction rephrased * spec/consensus: moved message handling to a new file * spec/consensus: improvements to message handling * spec/consensus: some fixes to design.md * spec/consensus: fixed pseudo-code in design.md * spec/consensus: moved picture to a local path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered specs entry point.
Part of #250:
specs/synchronizationdirectory for synchronization protocolsspecs/starknetdirectory for forced-updates, proof scheduling, and parts streamingspecs/network/discoverywith the discovery protocolspecs/network/gossipfor gossipsub documentationspecs/consensus/quintand fix all derived issuesCloses #609:
consensus/quintby removing thespecssubdirThis PR contains a lot of change, I am sorry for that. But notice that most changes are renames or moves. And a lot of actual changes are there to reflect the performed renames and moves.
PR author checklist