Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spec): fixed round update in RoundCSkip #630

Closed
wants to merge 1 commit into from
Closed

fix(spec): fixed round update in RoundCSkip #630

wants to merge 1 commit into from

Conversation

martin-hutle
Copy link
Contributor

Closes: #629

PR author checklist

@martin-hutle martin-hutle linked an issue Dec 3, 2024 that may be closed by this pull request
bug(spec): state round number not updated in RoundCSkip(r) #629
Closed
@romac romac changed the title fix(spec): fixed round update in roundcskipr fix(spec): fixed round update in RoundCSkip Dec 3, 2024
@romac
Copy link
Member

romac commented Dec 3, 2024

@martin-hutle Change looks good but looks like there is now a failing Quint test.

@martin-hutle
Copy link
Contributor Author

Apparently it is not a good idea to increase the round number on that event as this done by calling NewRoundCInput with r+1 in all tests. I need to do the new height logic differently then.
I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@cason cason Awaiting requested review from cason

@josef-widder josef-widder Awaiting requested review from josef-widder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(spec): state round number not updated in RoundCSkip(r)
2 participants
@martin-hutle @romac