Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Feature-gate metrics in core-consensus crate #762

Merged

Conversation

OakenKnight
Copy link
Member

@OakenKnight OakenKnight commented Jan 14, 2025

Closes: #681


PR author checklist

For all contributors

For external contributors

@romac romac changed the title feat(code): Feature-gating malachitebft-metrics in malachitebft-core-consensus crate feat(code): Feature-gate metrics in core-consensus crate Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (190f4a0) to head (15e62bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   75.87%   75.88%   +0.01%     
==========================================
  Files         170      170              
  Lines       14408    14418      +10     
==========================================
+ Hits        10931    10940       +9     
- Misses       3477     3478       +1     
Flag Coverage Δ
integration 75.54% <ø> (-0.01%) ⬇️
mbt 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@romac romac added this pull request to the merge queue Jan 15, 2025
Merged via the queue into informalsystems:main with commit daa4a5b Jan 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Feature-gate metrics in malachitebft-core-consensus crate
2 participants