Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issue when linting the VSCode plugin #1162

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Sep 13, 2023

Hello :octocat:

The CI task for linting VSCode plugin files is not currently using the local quint version. This causes problems when the published npm version is not compatible with the unpublished VSCode plugin version, causing errors like this. I copied the setup from the unit tests task to the linting task to make sure we can run linting in the CI in this scenario.

  • [-] Tests added for any new code
  • [-] Documentation added for any new functionality
  • [-] Entries added to the respective CHANGELOG.md for any new functionality
  • [-] Feature table on README.md updated for any listed functionality

@bugarela bugarela marked this pull request as ready for review September 13, 2023 14:12
@bugarela bugarela self-assigned this Sep 13, 2023
@bugarela bugarela enabled auto-merge September 14, 2023 11:53
@bugarela bugarela merged commit d08dccc into main Sep 14, 2023
15 checks passed
@bugarela bugarela deleted the gabriela/fix-vscode-linting-CI branch September 14, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants