Workaround for state vars from instances in incremental compilation (REPL) #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Our new flattener process is still not done incrementally (#1103). This will likely be a hard problem to solve.
Because of the re-flattening on each REPL evaluation (since it is not incremental), definitions from instances get fresh ids on each evaluation. This includes state variables, and therefore we had a problem (reported by @p-offtermatt on slack) where the values for variables were not persisting between evaluations.
The solution, for now, is to re-map the references to state variables from the old id to the new one. We do this by using the variable name which, after flattening, is guaranteed to be unique.
CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality