Apply improvements from effects system to the type system #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
commented
Oct 4, 2023
| // We cannot assign the result of a switch to a value, so we use an arrow function instead | ||
| const singleApplication = () => { | ||
| switch (t.kind) { | ||
| case 'var': { |
There was a problem hiding this comment.
idk what happen with the diff, but inside the switch, the only change is indentation.
shonfeder
approved these changes
Oct 4, 2023
thpani
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This implements items (3), (4) e (5) from #1203. I found this problems for the effect checker, but the type checker has similar issues, so this fixes them.
CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality