Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Wrap parsing and analysis in try...catch block #1205

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[LSP] Wrap parsing and analysis in try...catch block #1205

merged 3 commits into from
Oct 4, 2023

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Oct 4, 2023 •
edited
Loading

Hello :octocat:

This is a simple fix for the hanging on VSCode where it gave up on restarting the language server after 5 times. Even in unpredictable scenarios where we throw errors, this shouldn't happen.

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality
  • Feature table on README.md updated for any listed functionality

@bugarela bugarela self-assigned this Oct 4, 2023
@bugarela bugarela changed the title Wrap parsing and analysis in try...catch block [LSP] Wrap parsing and analysis in try...catch block Oct 4, 2023
@bugarela bugarela requested review from thpani and shonfeder October 4, 2023 14:24
shonfeder
shonfeder approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bugarela bugarela enabled auto-merge October 4, 2023 15:20
@bugarela bugarela merged commit e211d87 into main Oct 4, 2023
15 checks passed
@bugarela bugarela deleted the gabriela/catch-errors-on-language-server branch October 4, 2023 15:31
@bugarela bugarela mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shonfeder shonfeder shonfeder approved these changes

@thpani thpani Awaiting requested review from thpani

Assignees

@bugarela bugarela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugarela @shonfeder