-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error recovery between parsing phases #1220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great refactoring! I believe it makes it easier to understand what's going on. Also, the ability to accumulate errors is nice
Co-authored-by: Igor Konnov <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This PR makes it so we accumulate errors between parsing phases, instead of giving up after the first phase that results in error. In order to do that, we stop using
Either
monads, and instead using records with anerrors
field that accumulates the errors.There are also some changes to
ToIrListener.ts
so we have some error recovery - that is, we produce valid IR even if parsing fails. I'm trying to play with some specs to see if I can cause any of the assertions to fail, but for some reason it is looking pretty stable after my few changes.There's also a change in the JSON assets for testing, since now we are able to produce
modules
even if there are parsing errors.Example:
yields
CHANGELOG.md
for any new functionalityREADME.md
updated for any listed functionality