Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a REST URI to retrieve the number of checked-in visitors... #308

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

oliverhummel
Copy link
Contributor

@oliverhummel oliverhummel commented Jan 25, 2022

... in a room at a given moment.

Related Issue

Checklist

  • Is the code formatted correctly?
  • Unnecessary comments removed?
  • Printout statements removed?
  • If you made backend changes: Did all tests pass? Do you need to adjust some tests or write new ones?
  • Is your code easy to understand or do you need to insert some comments?
  • Explain the issue for the reviewer and your steps to solve the issue => makes it a lot more easy for the reviewer
  • Label your pull request (frontend/ backend/ testing/ styling/ sql/...)
  • Is the open source message included at the very beginning of every source code file?
  • Are all imports organized, i.e. are the imports up to date and have all package imports been removed?

@Gabril-E Gabril-E marked this pull request as draft January 27, 2022 16:14
@Gabril-E
Copy link
Collaborator

converted to draft until data-privacy concerns are resolved

@Gabril-E
Copy link
Collaborator

as long as only ctt-testserver is active, privacy concerns are negligible because no real data must be stored.

@Gabril-E Gabril-E marked this pull request as ready for review March 24, 2022 16:49
@oliverhummel
Copy link
Contributor Author

I would suggest that we add another environment variable to switch the API on or off and then deploy it on the testserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants