Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some synonym types #124

Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Jan 18, 2023

Related to #122 and #70

See template sheet in this PR at https://github.com/cthoyt/ontology-metadata/blob/add-synonym-types/src/templates/annotation_properties.tsv.

This PR also adds SSSOM mappings from these new terms to external vocabularies, specifically HP, in https://github.com/cthoyt/ontology-metadata/blob/add-synonym-types/src/ontology/components/omo-to-external.tsv

@matentzn
Copy link
Contributor

oh I should have told you that beforehand, sorry about that: https://github.com/information-artifact-ontology/ontology-metadata/blob/master/src/templates/annotation_properties.tsv

Forget we did that.. This template ensures we capture all necessary metadata in the right form;

I will see that I can prioritise finding Chris time for this because the first PR should be reviewed by he man himself. Just so we don't regret it later.

@cthoyt
Copy link
Contributor Author

cthoyt commented Mar 4, 2023

@matentzn i have now properly filled out the sheet so the appropriate ODK release commands can be used to turn the template into terms. should I do this in this PR, or it will get taken care of during release?

@matentzn
Copy link
Contributor

matentzn commented Mar 5, 2023

I will take it from here!

@cthoyt
Copy link
Contributor Author

cthoyt commented Mar 10, 2023

There are already a few exact property matches I want to encode in this PR from human phenotype ontology:

Whats the best way to do this?

@matentzn
Copy link
Contributor

I will encourage HPO to swap theirs out once this PR is in.

@cthoyt
Copy link
Contributor Author

cthoyt commented Mar 10, 2023

Either way, there will be artifacts of these in the wild for a long time until everyone has updated their HP imports. Wouldn't it be better to be defensive and plan for that situation?

@matentzn
Copy link
Contributor

Yes, you are right of course. Probably best to keep such mappings in a separate sssom file rather than adding them to the source, because what we don't want is all these IRIs being added to the vocab..

@cthoyt
Copy link
Contributor Author

cthoyt commented Mar 10, 2023

Yes, you are right of course. Probably best to keep such mappings in a separate sssom file rather than adding them to the source, because what we don't want is all these IRIs being added to the vocab..

Added in cthoyt@f188e8e

@matentzn
Copy link
Contributor

Nice!

@matentzn
Copy link
Contributor

Let's go ahead but documented permitted synonym scopes, and provide a core omo-synonym release (these are notes to me myself)

@matentzn matentzn requested a review from zhengj2007 May 8, 2023 09:18
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been open for a very long time.

Thanks @cthoyt for the repeated pings.

@matentzn matentzn merged commit 106b058 into information-artifact-ontology:master May 15, 2023
@cthoyt cthoyt deleted the add-synonym-types branch May 15, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants