Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SynonymType to SynonymTypeProperty #158

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

matentzn
Copy link
Contributor

This was a wrong naming, see #157

This was a wrong naming, see #157
@cthoyt
Copy link
Contributor

cthoyt commented Nov 1, 2023

I don't see any mention of SynonymTypeProperty in the OIO OBO file, only SynonymType: https://raw.githubusercontent.com/geneontology/go-ontology/master/contrib/oboInOwl.obo

@matentzn
Copy link
Contributor Author

matentzn commented Nov 2, 2023

@cthoyt can you review this? I want to merge and make a new release.

Copy link
Contributor

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @matentzn for being patient on this one and making a nice explanation!

@matentzn matentzn merged commit 584d2d9 into master Nov 2, 2023
1 check passed
@matentzn matentzn deleted the matentzn-patch-1 branch November 2, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants