Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acronym synonym type #159

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add acronym synonym type #159

merged 3 commits into from
Nov 2, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Nov 1, 2023 •
edited
Loading

Closes #135

From Jim's comment #135 (comment):

In discussion at OFOC meeting 2023-10-31 including csbjohnson and lschriml, there was consensus that we should create a new 'acronym' synonym type (not a new property).

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 2, 2023

@matentzn this was already approved by obo ops. Anything else to consider before we finish it?

matentzn
matentzn approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I much approve of the decision making process, but I am fine

@matentzn matentzn merged commit 40a7ae4 into information-artifact-ontology:master Nov 2, 2023
1 check passed
@matentzn matentzn mentioned this pull request Nov 2, 2023
Closed
@cthoyt cthoyt deleted the acronym-synonym branch November 2, 2023 12:11
@cthoyt cthoyt mentioned this pull request Nov 7, 2023
Open
@matentzn matentzn mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for has_acronym
2 participants
@cthoyt @matentzn