Add brand name synonym type #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes information-artifact-ontology#148, noting caveats brought up by @hoganwr in information-artifact-ontology#148 (comment).
|
Can we have this addressed first: OBOFoundry/OBOFoundry.github.io#2450 (comment) |
|
I'd like to try pushing this one more time. There are at least 5 ontologies that all have their own internal version of BRAND_NAME (chebi, fbbt, fbcv, and others that import chebi) because the synonyms don't get propagated in a nice way. I want to standardize all of these |
|
I cant help you push on this at the moment, so you may need to recruit some allies in slack.. Sorry about that. |
|
I 100% support an annotation property in OMO called 'brand name' (we can do
without caps and underscores).
I just don't think it is right to call it a "synonym type".
Bill
…On Wed, Feb 21, 2024 at 5:30 AM Charles Tapley Hoyt < ***@***.***> wrote:
I'd like to try pushing this one more time. There are at least 5
ontologies that all have their own internal version of BRAND_NAME (chebi,
fbbt, fbcv, and others that import chebi) because the synonyms don't get
propagated in a nice way. I want to standardize all of these
—
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJR55XOIBYE3IL6O3UWEULYUXLFXAVCNFSM6AAAAAA7VJCDKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGQ2TCNBYGA>
.
You are receiving this because you were mentioned.Message ID:
<information-artifact-ontology/ontology-metadata/pull/162/c1956451480@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148, noting caveats brought up by @hoganwr in #148 (comment).
This synonym type is useful for ChEBI, see discussion on their tracker at https://gitlab.ebi.ac.uk/chembl/chebi/chebi-2.0/chebi-ontology-generator/-/issues/27